Skip to content

ExtrudeGeometry: Change type of property "amount" to float #13937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2018
Merged

ExtrudeGeometry: Change type of property "amount" to float #13937

merged 1 commit into from
Apr 26, 2018

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 25, 2018

Fixes #13893

@WestLangley
Copy link
Collaborator

WestLangley commented Apr 25, 2018

In a separate PR, should we rename .amountto .depth?

@mrdoob mrdoob added this to the r93 milestone Apr 26, 2018
@mrdoob mrdoob merged commit efee9d0 into mrdoob:dev Apr 26, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 26, 2018

Thanks!

@Mugen87 Mugen87 mentioned this pull request Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r93

Development

Successfully merging this pull request may close these issues.

3 participants

@Mugen87 @WestLangley @mrdoob