FBXLoader: Fix Filename to RelativeFilename in parseImage() #13875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path of "Filename" property is useless. It depends on local directory (ex. C:\somewhere\blahblah\shitty.fbx). RelativeFilename is better for URI.
Mugen87
changed the title
Collaborator
|
You'll need to update the line below as well to prevent breaking embedded images: To |
Owner
|
Thanks! |
Contributor
Author
|
Awesome! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path of "Filename" property is useless. It depends on local directory (ex. C:\somewhere\blahblah\somefile.fbx). RelativeFilename is better for URI.
I made a tiny example in codesandbox ( https://codesandbox.io/s/y2kv8yyw5j ).
enjoy it! 💃