CSS3DRenderer: Use WeakMap for styles cache. #13867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would use a WeakMap instead. |
|
make sense and sounds better, I will change it thanks! |
yomotsu
commented
Apr 16, 2018
| function zOrder( scene ) { | ||
| function filterAndFlatten( scene ) { | ||
|
|
||
| var order = Object.keys( cache.objects ).sort( function ( a, b ) { |
There was a problem hiding this comment.
This is only for IE11 (to sort by Z).
Cached Object.keys will not work anymore, since it cached in a WeakMap. To make an array, I added a function called filterAndFlatten
|
Now it uses a WeakMap for the cache. It works even in IE11😊 |
mrdoob
changed the title
|
Thanks! |
Repository owner
deleted a comment
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS3Renderer caches CSS3DObject's css styles in a scoped pool.
However, once the style is added to the pool, it will never be removed, even with
scene.remove( css3DObject ), then memory leak occurs.This PR is to solve the possibility of memory leak.