Skip to content

Honor matrixAutoUpdate flag in serialization #13840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2018
Merged

Honor matrixAutoUpdate flag in serialization #13840

merged 1 commit into from
Apr 14, 2018

Conversation

@WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Apr 12, 2018 •
edited by mrdoob
Loading

Fixes #13828

@WestLangley
Copy link
Collaborator Author

WestLangley commented Apr 12, 2018

Maybe there are other places where this needs to be addressed... Not sure...

@WestLangley WestLangley mentioned this pull request Apr 14, 2018
Closed
@mrdoob mrdoob added this to the r92 milestone Apr 14, 2018
@mrdoob mrdoob merged commit 12e7e07 into mrdoob:dev Apr 14, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 14, 2018

Thanks!

@crubier
Copy link

crubier commented Apr 14, 2018

Thanks !

@WestLangley
Copy link
Collaborator Author

WestLangley commented Apr 14, 2018

@Mugen87 Do you have a feeling for what additional changes need to be made to honor matrixAutoUpdate on export/import?

@WestLangley WestLangley deleted the dev-matrixAutoUpdate branch April 14, 2018 19:52
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 15, 2018

Since you've already changed ObjectLoader and Object3D, there should be no more work to do.

@WestLangley
Copy link
Collaborator Author

WestLangley commented Apr 15, 2018

@Mugen87 Good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r92

Development

Successfully merging this pull request may close these issues.

4 participants

@WestLangley @mrdoob @crubier @Mugen87