Skip to content

Clean up WebGLExtensions #13744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

Clean up WebGLExtensions #13744

merged 1 commit into from
Apr 3, 2018

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Apr 2, 2018

I think we can remove case 'WEBGL_compressed_texture_etc1'

@mrdoob
Copy link
Owner

mrdoob commented Apr 3, 2018

Hmm... Why?

@takahirox
Copy link
Collaborator Author

takahirox commented Apr 3, 2018 •
edited
Loading

Because it can be handled by the following default

default:
	extension = gl.getExtension( name );

@mrdoob
Copy link
Owner

mrdoob commented Apr 3, 2018

True.

@mrdoob mrdoob added this to the r92 milestone Apr 3, 2018
@mrdoob mrdoob merged commit 9b0ae03 into mrdoob:dev Apr 3, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r92

Development

Successfully merging this pull request may close these issues.

2 participants

@takahirox @mrdoob