Skip to content

GLTFExporter: Ensure joints are uint8 or uint16. #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2018
Merged

GLTFExporter: Ensure joints are uint8 or uint16. #13609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
655fc34
GLTFExporter: Ensure joints are uint8 or uint16.
donmccurdy Mar 16, 2018
9c00e9a
GLTFExporter: Clean up skinIndex conversion.
donmccurdy Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions examples/js/exporters/GLTFExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,17 @@ THREE.GLTFExporter.prototype = {
var attribute = geometry.attributes[ attributeName ];
attributeName = nameConversion[ attributeName ] || attributeName.toUpperCase();

// JOINTS_0 must be UNSIGNED_BYTE or UNSIGNED_SHORT.
var array = attribute.array;
if ( attributeName === 'JOINTS_0' &&
! ( array instanceof Uint16Array ) &&
! ( array instanceof Uint8Array ) ) {

console.warn( 'GLTFExporter: Attribute "skinIndex" converted to type UNSIGNED_SHORT.' );
attribute = new THREE.BufferAttribute( new Uint16Array( array ), attribute.itemSize, attribute.normalized );

}

if ( attributeName.substr( 0, 5 ) !== 'MORPH' ) {

attributes[ attributeName ] = processAccessor( attribute, geometry );
Expand Down