Skip to content

GLTFLoader: Clean up extensions example. #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2018
Merged

GLTFLoader: Clean up extensions example. #13596

merged 2 commits into from
Mar 15, 2018

Conversation

@donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Mar 15, 2018

  • Replaces custom HTML with dat.gui
  • Simplifies code, removes camera selection
  • Adds author and title for each example

Before | After

/cc @takahirox

@donmccurdy donmccurdy force-pushed the examples-gltfloader-cleanup branch from 253734b to 9705671 Compare March 15, 2018 01:11
@mrdoob mrdoob added this to the r92 milestone Mar 15, 2018
@mrdoob mrdoob merged commit 566f53d into mrdoob:dev Mar 15, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2018

Thanks!

@donmccurdy donmccurdy deleted the examples-gltfloader-cleanup branch July 9, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r92

Development

Successfully merging this pull request may close these issues.

2 participants

@donmccurdy @mrdoob