Skip to content

Conversation

@takahirox
Copy link
Collaborator

This PR flattens concatenated UUID strings with .toUpperCase() to save heap memory space.

See: #13069 #13094

Let us know if you have use case where this performance degradation becomes a serious problem.

Refer to #13069 (comment) for the performance and memory consumption comparison.

@mrdoob mrdoob added this to the r92 milestone Mar 15, 2018
@mrdoob mrdoob merged commit f071a86 into mrdoob:dev Mar 15, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants