-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Make WebGLRenderer.setViewport(), setScissor() relative to lower-left corner #13593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now, Also, .setViewport() now follows the same convention as Aside: |
|
Yeah, I also think it's better to stick to the WebGL conventions. |
|
I have other PRs in the pipeline that depend on this correction. /ping @Mugen87 I don't know what else I can do. |
|
I'm fine with this change 😇 |
|
Thanks! 😅 |
Fixes #12210.
When specifying the viewport and the scissor box, (x, y) is the coordinate of the lower left corner of the rectangular region.
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/viewport