-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
EXAMPLES: Updated webgl_materials_cars example to use GLTF model #13337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The model seems to be missing parts. Maybe do this as a workaround: carModel.traverse( function( node ) { if ( node instanceof THREE.Mesh ) { node.material.side = THREE.DoubleSide } } );Maybe find a better model? |
|
I've done quite a bit of work on the model so far, it still has a couple of missing bits \ tiny gaps but I'll fix them in a separate PR since this model is used across a couple of examples. It can mostly be fixed by adding a bottom plate to the car and adding an inside surface to the body. BTW I did previously submit a different model (Dodge viper) but was told I should use a model already in the repo... |
|
Just curious to know what the main purpose of switching to glTF model is. |
|
We're working on deprecating the old BinaryLoader. The examples using these car models are the only remaining places it's used. |
|
Gotcha |
|
BTW do we still need |
|
I would be ok with removing it. To be honest, there are quite a few examples like this, that either demonstrate something outdated, or don't really demonstrate any feature but just look good, or are duplicates of other examples. While it's great to have this huge body of examples, having too many is actually counterproductive since they don't get updated and end up demonstrating out of date techniques (for example, many examples still use Geometry rather than BufferGeometry). |
|
Yeah, I think we can remove Any thoughts? @mrdoob |
|
There are now 3 PRs that use this updated car model: this one and #13084, #13314 Two questions have been raised: 1. As @WestLangley pointed out above there are some issues with this model - in particular the interior is missing a couple of pieces. I can either
2. Is this example (materials_cars) worth keeping? Or should we remove it? @mrdoob can you provide feedback here before I proceed in this? |
|
/ping @mrdoob for feedback. |
|
Sorry for the delay. This PR is looking good! I'll polish it in the next cycle 👌 |
There no rush, just didn't want this to gather too much dust. 🙂 |
|
Closed in favour of #14843 |
Although now it should really be called
webgl_materials_carsince there's only one car model 😅New version
Old version