Update Geometry.js #13254
Closed
Update Geometry.js #13254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Geometry.merge function doesn't copy the second UV set, with this change is does.
mrdoob
reviewed
Feb 5, 2018
Collaborator
|
Is this still relevant with Geometry support being removed from renderer and animation code, or do we want to limit Geometry changes to bug fixes at this point? |
Contributor
Author
|
I think this fix should be merged before Geometry is renamed LegacyGeometry and moved to Three.Legacy.js |
Collaborator
|
I'm afraid this PR is not correct. A second set of uvs is define in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Geometry.merge function doesn't copy the second UV set, with this change is does.