FBXLoader conditional animation parsing #12446
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FBXLoader currently creates a skeleton for all loaded models, whether or not they contain an animation. It then dumps everything (not just bones, but all meshes, groups, lights, cameras etc.) into the skeleton and uses that to link the animation.
As the comment mentions, this is quite a hacky way of doing things and should be rewritten, but in the meantime this at least solves the problem for files that don't contain any animation.