Skip to content

Examples: Simplify webgl_loader_json_blender #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2017
Merged

Examples: Simplify webgl_loader_json_blender #11109

merged 3 commits into from
Apr 2, 2017

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 2, 2017

This PR removes the collada model so it's easier to understand the loading and processing of the json model file (Blender export). I've also done some clean up.

@jostschmithals
Copy link
Contributor

Good deed! From my point of view it is very useful to focus the examples on one single aspect like you did it here (since these are for learning purposes). I always felt that for a beginner (like me) it is much harder to understand them if several things are mixed up.

@Mugen87 BTW (since you are so busy) : I would like to make a thorough revision of the webgl_animation_skinning_blending example, where I notice some bugs and some remnants of legacy code – or are you currently doing the same (we should avoid doubling the work)?

@jostschmithals
Copy link
Contributor

An additional suggestion:

What about changing .setDuration( 1 ) to .setDuration( 1000 * s ) in line 99?

In this way the smaller monsters would have to make more effort to keep up with the others and the crowd would look more realistic.

One could also reduce the lower limit in line 87 to make the effect more noticeable (try 0.00015 and watch the monster babies 😉 ).

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 2, 2017

I would like to make a thorough revision of the webgl_animation_skinning_blending example, where I notice some bugs and some remnants of legacy code – or are you currently doing the same (we should avoid doubling the work)?

Nope. Nice that you revisit this example.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 2, 2017

since you are so busy

Not really. 😁 It could be worse.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 2, 2017

I think the settings are okay like that. In this way the example is straightforward.

@mrdoob mrdoob merged commit f6e0053 into mrdoob:dev Apr 2, 2017
@mrdoob
Copy link
Owner

mrdoob commented Apr 2, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants