-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Closed
Labels
Milestone
Description
Description
When the bloom radius > 1, the effect starts to "invert". See below:
radius = 0.66:
radius = 1.52:
radius = 5:
Is this intended behavior? Should the radius be clamped between 0 and 1?
Reproduction steps
- Edit the radius slider on any bloom example like unreal bloom to accept values larger than 1
- Move the radius slider > 1 and observe the invert
Code
The lerpBloomFactor in the frag shader in UnrealBloomPass.js can produce negative values when bloomRadius is > 1
three.js/examples/jsm/postprocessing/UnrealBloomPass.js
Lines 473 to 476 in 7a4f6b6
| float lerpBloomFactor(const in float factor) { | |
| float mirrorFactor = 1.2 - factor; | |
| return mix(factor, mirrorFactor, bloomRadius); | |
| } |
For a repro, see below jsfiddle.
Live example
Screenshots
See above
Version
latest
Device
No response
Browser
No response
OS
No response