-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
Closed
Labels
Milestone
Description
Description
Thank you for this amazing library! I'm using it to build my own project for years. I'm using three.js with a TypeScript project and found a minor issue with types given for different KeyframeTrack
implementations. I use typings generated by @types/three
Reproduction steps
- Check generic type of array
values
forKeyframeTrack
implementations like:StringKeyframeTrack
,BooleanKeyframeTrack
,ColorKeyframeTrack
,VectorKeyframeTrack
,QuaternionKeyframeTrack
- Notice that all typings say
Array<number>
regardless of the actual implementation or the correctly givenValueTypeName
I expect the respective generic type to match with the implementation class type. So for
StringKeyframeTrack
: I expectArray<string>
in the docs commentBooleanKeyframeTrack
: I expectArray<boolean>
in the docs commentColorKeyframeTrack
: I expectArray<Color>
in the docs commentVectorKeyframeTrack
: I expectArray<Vector2 | Vector3 | Vector4>
in the docs commentQuaternionKeyframeTrack
: I expectArray<Quaternion>
in the docs comment
Code
tbd
Live example
tbd
Screenshots
No response
Version
178
Device
No response
Browser
No response
OS
No response