PropertyBinding on `.material.color` doesn't set `needsUpdate`

[tommie]

Description

It seems PropertyBinding isn't selecting the right setValue, because Material.needsUpdate only has a setter defined, not a getter, and the check is against undefined.

The solution is probably to use "material" in targetObject, since a getter isn't easily defined without knowing the compiled version:

three.js/src/animation/PropertyBinding.js

Lines 572 to 580 in 3df50b7

	if ( targetObject.needsUpdate !== undefined ) { // material
	versioning = this.Versioning.NeedsUpdate;
	} else if ( targetObject.matrixWorldNeedsUpdate !== undefined ) { // node transform
	versioning = this.Versioning.MatrixWorldNeedsUpdate;
	}

Reproduction steps

See console of live example.

Code

import * as THREE from 'three';

const material = new THREE.MeshBasicMaterial();
const mesh = new THREE.Mesh(undefined, material);
const binding = THREE.PropertyBinding.create(mesh, ".material.color");

binding.bind();
binding.setValue([0.5, 0.5, 0.5], 0);

console.log(material.version);

Live example

https://jsfiddle.net/pq1vLgjc/

Screenshots

No response

Version

r169

Device

No response

Browser

No response

OS

No response

[Mugen87]

three.js/src/animation/PropertyBinding.js

Line 572 in 88aa95a

if ( targetObject.needsUpdate !== undefined ) { // material

When this line is only relevant to determine the updating versioning scheme, we could simply do this:

if ( targetObject.isMaterial === true ) { // material 

@tommie What do you think?

[Mugen87]

In general, it seems more clean to check the object types. So the entire code block could be written like so:

if ( targetObject.isMaterial === true ) { // material

	versioning = this.Versioning.NeedsUpdate;

} else if ( targetObject.isObject3D === true ) { // node transform

	versioning = this.Versioning.MatrixWorldNeedsUpdate;

}

[tommie]

if ( targetObject.isMaterial === true ) { // material

I don't understand why the comparison to true is required, but yes, that seems good.

The "node transform" comment seems odd, and only Object3D has a matrixWorldNeedsUpdate: https://github.com/search?q=repo%3Amrdoob%2Fthree.js%20matrixworldneedsupdate&type=code