Nodes: Line2NodeMaterial dash mode broken

[aardgoose]

Description

The PR #28585 appears to have broken Line2NodeMaterial. Reverting the PR fixes the error.

In dashed mode, the fragment shader fails to compile with the error in

three.js/src/nodes/materials/Line2NodeMaterial.js

Line 269 in 0679c55

const lineDistance = positionGeometry.y.lessThan( 0.5 ).cond( dashScaleNode.mul( instanceDistanceStart ), materialLineScale.mul( instanceDistanceEnd ) );

If the multiplications within the cond() expression are removed, the shader compiles as expected.

Reproduction steps

1. run the example webgpu_lines_fat
2. select 'dashed' to enable dashed line mode.

Code

n/a

Live example

Line2NodeMaterials example

Screenshots

No response

Version

166

Device

No response

Browser

No response

OS

No response

[Mugen87]

I had a few issues with cond() as well when porting code to TSL. Out of curiosity, does it work if the code is change to the following?

const lineDistance = float( 0 ).toVar();

If( positionGeometry.y.lessThan( 0.5 ), () => {

    lineDistance.assign( dashScaleNode.mul( instanceDistanceStart ) );

} ).else( () => {

    lineDistance.assign( materialLineScale.mul( instanceDistanceEnd ) );

} );

[aardgoose]

Yes and no (with a float( 0 ).toVar();

It doesn't produce an invalid shader, but doesn't work as expected. Presumably because If() uses cond() internally.

[Mugen87]

Ah yes, the toVar() is required in this case.

In any event, this was just intended as a possible workaround. Of course it's best to make the normal cond() usage work.