FirstPersonControls should repect intial object rotation

[makc]

Consider this to be a feature request, I guess? Both #3010 and #6551 were closed as help, and all of relevant SO questions are either unanswered, or the answer is "set lat and lon".

So why dont you set lat and lon to the values corresponding to object.rotation rather than to 0 in FirstPersonControls constructor?

[makc]

This is the patch I applied on the project:

//	this.lat = 0;
//	this.lon = 0;
//	this.phi = 0;
//	this.theta = 0;
	var target = new THREE.Vector3(0, 0, -1);
	var matrix = new THREE.Matrix4();
	object.updateMatrix();
	matrix.extractRotation(object.matrix);
	target.applyMatrix4(matrix);
	this.phi = Math.acos(target.z / target.length());
	this.theta = Math.atan2(target.y, target.x);
	this.lat = 90 - THREE.Math.radToDeg(this.phi);
	this.lon = THREE.Math.radToDeg(this.theta);

Idk if it is entirely correct, because I had to add PI/2 to object.rotation.y in another place (suspected loader problem) but maybe this patch has a bug.

disregard that, I removed PI/2 and the patch still works.

and now it does not again. need my PI/2 back :)

[Mugen87]

I think the feature request is valid. I just wonder if the implementation could raise wrong expectations. What if a user wants to use camera.lookAt() during rendering? In this case, the computed rotation would be overwritten by FirstPersonControls.

[mrdoob]

Would a controls.setOrientation() do the trick?

[Mugen87]

Yeah, I think so 👍

[Mugen87]

What do you folks think about this approach:

this.setOrientation = function () {

	var lookDirection = new THREE.Vector3();
	var spherical = new THREE.Spherical();

	return function setOrientation( quaternion ) {

		lookDirection.copy( this.forward ).applyQuaternion( quaternion );
		spherical.setFromVector3( lookDirection );

		this.lat = 90 - THREE.Math.radToDeg( spherical.phi );
		this.lon = THREE.Math.radToDeg( spherical.theta );

                return this;

	};

}();

This would allow to set the orientation of the controls based on a quaternion. this.forward is a new property with a default value of ( 0, 0, - 1). The user can do this now (assuming the camera has not parent):

camera.lookAt( targetPosition );
controls.setOrientation( camera.quaternion );

[makc]

as long as it works :)

[Mugen87]

It worked on my computer^^. Let me do a PR 👍