Add a getter for "session" in WebXR

[soadzoor]

Description of the problem

It would be very helpful if I could get the session, and the XRInputDevice, specially the "handedness", and "pointerOrigin" properties. The only way I find to do this now, is by changing my three.js file, which obviously not a nice solution.

I think the best way would be something like this:
var session = renderer.vr.getSession();, then
var inputDevice = session.getInputSources();

Or is there already a way to get this, and I couldn't find it..?

Three.js version

• Dev
• r94
• ...

Browser

• All of them
• Chrome
• Firefox
• Internet Explorer

OS

• All of them
• Windows
• macOS
• Linux
• Android
• iOS

[mrdoob]

Could you add links to the specific parts of the WebXR API you're referring to?

[soadzoor]

@mrdoob Maybe this is the one: https://immersive-web.github.io/webxr/#xrinputsource-interface

The XRinputsource is logged on the console in three.js when you use a compatible VR device (and browser), but as far as I know, there's no way to get the same "information" without modifying three.js, (or maybe WebVR.js (from the examples))

[mrdoob]

Is this to know if the VR controller is for the left hand or the right hand?

[soadzoor]

Partially, yes! For me, personally, it would be very useful to check if the user even HAS a hand-controller (so they use a VR headset like daydream), or not (so they use a VR headset like google cardboard).

"What would be the point of all this?" You might ask. The answer is that if (s)he uses a handcontroller, then I add a helper (like in the webvr ballshooter example), because it's very useful. If it doesn't have a handcontroller, then I don't add it, because it's very disturbing in this case (as the helperline is coming right from the user's "nose").

[mrdoob]

If it doesn't have a handcontroller, then I don't add it, because it's very disturbing in this case (as the helperline is coming right from the user's "nose").

Haha, yeah. I noticed that. What's wrong with shooting balls with your nose? 😁

One option would be to user the userData:

var controller = renderer.vr.getController( 0 );
console.log( controller.userData.vr.hand ); // 'left'

Would that work? What other data is available/needed?

[soadzoor]

Would that work? What other data is available/needed?

There's also a data called pointerOrigin. And I believe hand should be called handedness instead, so it would be consistent with the properties of XRInputSource

This is what it looks like with cardboard:

[mrdoob]

Maybe for the time being we can add that object direction into the controller's userData?

[soadzoor]

Yea, I believe that should be okay :)

[mrdoob]

Yay! Would you like to do a PR? ^^

[soadzoor]

Yea, I'll try :)

[soadzoor]

@mrdoob It seems I don't have a permission to push into this repo :(

[Mugen87]

Try to fork the repository and then create a pull request. More information about contributing right here:

https://github.com/mrdoob/three.js/wiki/How-to-contribute-to-three.js

[soadzoor]

@Mugen87 Yea, I read that, but it doesn't mention forking, that's the reason for my misunderstanding. I think I got it now, thanks! Here it is: #14813

[soadzoor]

Any reason why the PR is not merged yet? :/