Ambient Occlusion is not working great with antialiasing

[kapilgp]

HI Team,

I have tried https://threejs.org/examples/?q=ssa#webgl_postprocessing_ssao for ambient occlusion. It is showing shadow but antialias is not working with that.

As I applied ambient occlusion it added some lines at outer side of the model and renderer loose antialias.

Is it known issue or is there anything where we can do something else.

Three.js version

• prod
• r83
• ...

Browser

• All of them
• Chrome
• Firefox
• Internet Explorer

OS

• All of them
• Windows
• Linux
• Android
• IOS

Hardware Requirements (graphics card, VR Device, ...)

[bhouston]

Our SSAO is completely broken, it isn't even a proper SSAO algorithm. It appears to just to use the normal compared to the forward direction and makes things darker the more these two directions differ. That isn't SSAO. I think the code broke a years ago and never got fixed.

[kapilgp]

So is there any chance to fix it? And can you please let me know the other way for the same effect. It is great help for me.

…

On Tue, Jan 31, 2017 at 9:58 PM, Ben Houston (Clara.io) < ***@***.***> wrote: Our SSAO is completely broken, it isn't even a proper SSAO algorithm. It appears to just to use the normal compared to the forward direction and makes things darker the more these two directions differ. That isn't SSAO. I think the code broke a years ago and never got fixed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10688 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHw6G61bCTVcLlLigF_HlKxhT-hPld8wks5rX2FFgaJpZM4LyUuY> .

-- Many Thanks, Kapil Gupta Call me: +91 94130-14600 Email: kapil.gp@gmail.com Web: http://www.aboutbharat.info

[makc]

@bhouston

use the normal compared to the forward direction and makes things darker the more these two directions differ

but then this should not have any need to work as postprocessing and thereby cause antialiasing issues

[makc]

@kapilgp postprocessing uses rendering to texture and that operation ignores antialiasing setting. your only option is to use higher resolution texture there, but that will slow things down by a lot.

[makc]

@bhouston btw, this ticket gave me an idea: why not have some util that bakes ao into vertex attribute (not sure if belongs in main repo, though)? should be perfect for static scenery, such as buildings/furniture. edit: although it will need dense grids, simple cube will not work, for example

[kapilgp]

@makc using aoMap texture is also in my mind, but due to performance I am not preferring.

@bhouston that idea seems good, if we can bake ao through vertex. As I also have static car model so I think it will be fit in that.

Please update me as you can create utility for that.

[bhouston]

There is already Substance Designer that can bake AO, etc. I'd suggest that.

[mrdoob]

@makc https://www.clicktorelease.com/code/codevember-2016/7/

[bhouston]

I think @mrdoob is referring to the SSAO example here: https://www.clicktorelease.com/code/codevember-2016/12/

[makc]

@mrdoob well, for AO you would only have to check maybe a dozen of rays per vertex, to see how far they go, no need to constantly render stuff and pause to read it back

[makc]

@bhouston I think he replies to baked AO comment

[kapilgp]

Thanks @mrdoob, Let me try the same.

[pailhead]

is rendering the ao before the main image and then using it as a mask of sorts out of the question? Adds the texture fetching and for possibly invisible fragments but it should work better with AA

[makc]

@pailhead I guess you could do that manually if you change every material you use in the scene.

[bhouston]

@pailhead you mean this approach: #7424