Support postman collection input #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mquan
commented
Aug 9, 2023
| defaultTag: "General", | ||
| }); | ||
|
|
||
| return JSON.parse(oas); |
There was a problem hiding this comment.
Types inference can be done here, so we're not totally blocked by postman-to-openapi. However, there's still no way to infer required from the collection.
mquan
commented
Aug 9, 2023
| }; | ||
|
|
||
| const parseJSON = async (filename: string) => { | ||
| const rawText: string = await fs.readFile(filename, "utf8"); |
There was a problem hiding this comment.
Currently only supports local file, need remote file support to be consistent with SwaggerParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/joolfe/postman-to-openapi to convert from postman to OpenAPI Spec.
🚫 Blockers:
schema types in raw body aren't inferred. Project isn't maintained, the following issues have been opened for 6months+
Generating Schemas from examples joolfe/postman-to-openapi#237
Schema generation joolfe/postman-to-openapi#246
Even after above hurdle there's no way to tell if a parameter is required or not
Both stem from postman collection being a bad standard to store API spec