Fix Uncaught TypeError: options.icon.slice is not a function when using L.AwesomeMarkers.icon on startIcon and endIcon

[SubiNesa]

No description provided.

[SubiNesa]

#161

[mpetazzoni]

Thanks for the PR! This breaks setting icons for categories/waypoint types though, which are expected to be set with:

markers: {
    wptIcons: {
      'Coffee shop': new L.AwesomeMarkers.icon({
        icon: 'coffee',
        prefix: 'fa',
        markerColor: 'blue',
        iconColor: 'white'
      })
    }
}

Can you find a way to tell those situations apart in _prepare_markers() ?

[SubiNesa]

Thanks for your comment.
I am little bit confused, wouldn't that be this line https://github.com/mpetazzoni/leaflet-gpx/blob/main/gpx.js#L292 ?

I could add new condition for startIcon and endIcon, but not sure if that would be overkill

[mpetazzoni]

Ah yes you're right, I already had to handle that case because type(null) === 'object'