Fix test_parse_arguments_multiarch_cache_disabled #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails when SCCACHE_CACHE_MULTIARCH is set, which can either happen externally, or when another tests sets it via with_var. with_var_unset prevents both (temp_env has a global lock specifically to avoid the problem with concurrent tests). Fixes mozilla#1982
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1984 +/- ##
==========================================
- Coverage 30.69% 30.64% -0.06%
==========================================
Files 51 51
Lines 19192 19194 +2
Branches 9230 9230
==========================================
- Hits 5891 5882 -9
+ Misses 7760 7759 -1
- Partials 5541 5553 +12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails when SCCACHE_CACHE_MULTIARCH is set, which can either happen externally, or when another tests sets it via with_var.
with_var_unset prevents both (temp_env has a global lock specifically to avoid the problem with concurrent tests).
Fixes #1982