Properly implement PCH compilation #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would need tests, could you please add some? thanks |
|
Okay, I added some tests. Let me know if I should add another specific test. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
+ Coverage 29.39% 29.58% +0.19%
==========================================
Files 49 49
Lines 17713 17781 +68
Branches 8547 8577 +30
==========================================
+ Hits 5206 5260 +54
- Misses 7348 7350 +2
- Partials 5159 5171 +12
☔ View full report in Codecov by Sentry. |
|
I force pushed to address the failing lint CI |
sylvestre
reviewed
Jun 9, 2023
jimis
reviewed
Nov 26, 2024
| Language::C => "c", | ||
| Language::Cxx => "c++", | ||
| Language::C | Language::CHeader => "c", | ||
| Language::Cxx | Language::CxxHeader => "c++", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1748.
A proper bug explanation is provided in the above mentioned issue.
Since we need to differentiate between header and source for PCH compilation, we store the file type information (header vs source) and then pass that along to clang/gcc via
-x. Since.h("GenericHeader") can be either a header or a source, the-xwill be omitted for.hunless manually specified by the user, so the compiler can decide what to do.