-
Notifications
You must be signed in to change notification settings - Fork 904
Separate idea of parent and declaration scopes, and fix scopes for built in lambda based functions. #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Separate idea of parent and declaration scopes, and fix scopes for built in lambda based functions. #2116
Conversation
|
Making this as a draft because I think there are things that I should tidy up in the byte code compiler, but haven't checked those yet. |
13cf163 to
fd73cea
Compare
|
I've rebased this on top of master. The improved I think there may be further lurking horrors around promises, but I don't think they are something we should fix until we've sorted out |
fd73cea to
55f46f3
Compare
|
Thanks -- I'm all for cleaning up the weirdness and complexity about scopes. This is a pretty important and fundamental change, though -- can we put some documentation in the Function interface, and maybe even elsewhere, to explain to future users of Rhino what the difference is and what each type of scope means? Thanks! |
55f46f3 to
d7f9e21
Compare
|
I've added a little Javadoc to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK -- I get what we're doing here and I am supportive of moving away from the confusing world of parent scopes for objects. I also am worried about the many projects that may have depended on some of this functionality over the years, since we had to change a few really old tests to make this work.
I still think that this is OK, but I am going to wait a day or so to see if anyone else has some strong opinions. Thanks!
d7f9e21 to
2bd9fd3
Compare
This fixes #2104 and will enable a follow PR to resolve issues with property descriptor creation.