Fix length with default arguments #2115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xe
force-pushed
the
scratch/satish/def-args-length
branch
from
8442cbd to
697c734
Compare
| } | ||
| } | ||
| } | ||
| if (arity != paramCount) break; |
There was a problem hiding this comment.
Shouldn't need this if - the only time you assign arity is at like 538, which is already followed by a break
| if (params != null && !params.isEmpty()) { | ||
| for (int i = 0; i < defaultParams.size(); i += 2) { | ||
| if (defaultParams.get(i) instanceof String) { | ||
| String paramWithDefault = (String) defaultParams.get(i); |
There was a problem hiding this comment.
Nit: I would just declare this before the if above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec says length should only include arguments up to the first default argument. This ensures we adhere to that.