[Editor] Cleanup the pages not being fully rendered before switching to editing mode #20258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to editing mode In order to see the issue this patch is fixing: - open a pdf with some highlights and a comment on page 1, at page 7 - open the comment sidebar - click on the comment on page 1 Opening at page 7 lets a not fully rendered page which means that when jumping to it with the sidebar, we re-use what we've instead of redrawing it.
timvandermeij
approved these changes
Sep 11, 2025
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 2 Live output at: http://54.241.84.105:8877/1f32e9775db0751/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/741493dff0e740d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1f32e9775db0751/output.txt Total script time: 18.13 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/741493dff0e740d/output.txt Total script time: 40.97 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to see the issue this patch is fixing:
Opening at page 7 lets a not fully rendered page which means that when jumping to it with the sidebar, we re-use what we've instead of redrawing it.