Skip to content

[Annotation] Use the new popup in reading mode (bug 1987426) #20250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

[Annotation] Use the new popup in reading mode (bug 1987426) #20250

merged 1 commit into from
Sep 15, 2025
+236 −74

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman force-pushed the new_popup_reading_mode branch from c76612b to ee60d59 Compare September 12, 2025 09:14
timvandermeij
timvandermeij approved these changes Sep 14, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comment addressed. Thank you!

@calixteman calixteman force-pushed the new_popup_reading_mode branch 2 times, most recently from 1075190 to fb241b0 Compare September 15, 2025 07:14
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e0f20502e73d498/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9c45a9eae3f746c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e0f20502e73d498/output.txt

Total script time: 22.89 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9c45a9eae3f746c/output.txt

Total script time: 45.82 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the new_popup_reading_mode branch from fb241b0 to b88e07a Compare September 15, 2025 14:05
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c2fc7440434c845/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6fd5f1461ce0adc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6fd5f1461ce0adc/output.txt

Total script time: 20.29 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the new_popup_reading_mode branch from b88e07a to 38b86cb Compare September 15, 2025 14:58
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9659fa733f9d07a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/90d89913c1f3801/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c2fc7440434c845/output.txt

Total script time: 43.64 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9659fa733f9d07a/output.txt

Total script time: 18.39 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/90d89913c1f3801/output.txt

Total script time: 39.72 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 394fa2c into mozilla:master Sep 15, 2025
9 checks passed
@calixteman calixteman deleted the new_popup_reading_mode branch September 15, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @timvandermeij