ci: Try cargo-careful
#2607
Draft
ci: Try cargo-careful
#2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that RalfJung/cargo-careful#35 got fixed.
|
Except that fix isn't in a release yet. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 37c3aee. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark results1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: time: [694.67 ms 698.59 ms 702.50 ms]
thrpt: [142.35 MiB/s 143.15 MiB/s 143.95 MiB/s]1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: time: [351.58 ms 353.08 ms 354.59 ms]
thrpt: [28.202 Kelem/s 28.322 Kelem/s 28.443 Kelem/s]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: time: [25.566 ms 25.735 ms 25.916 ms]
thrpt: [38.587 elem/s 38.858 elem/s 39.114 elem/s]
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: time: [1.8442 s 1.8652 s 1.8874 s]
thrpt: [52.984 MiB/s 53.613 MiB/s 54.224 MiB/s]
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high milddecode 4096 bytes, mask ff:time: [12.090 µs 12.129 µs 12.175 µs] Found 19 outliers among 100 measurements (19.00%) 3 (3.00%) low severe 3 (3.00%) low mild 2 (2.00%) high mild 11 (11.00%) high severe decode 1048576 bytes, mask ff:time: [3.1246 ms 3.1305 ms 3.1382 ms] Found 5 outliers among 100 measurements (5.00%) 1 (1.00%) low mild 4 (4.00%) high severe decode 4096 bytes, mask 7f:time: [20.154 µs 20.205 µs 20.262 µs] Found 20 outliers among 100 measurements (20.00%) 1 (1.00%) low severe 4 (4.00%) low mild 2 (2.00%) high mild 13 (13.00%) high severe decode 1048576 bytes, mask 7f:time: [5.2474 ms 5.2589 ms 5.2720 ms] Found 14 outliers among 100 measurements (14.00%) 14 (14.00%) high severe decode 4096 bytes, mask 3f:time: [7.0034 µs 7.0227 µs 7.0509 µs] Found 14 outliers among 100 measurements (14.00%) 4 (4.00%) low severe 4 (4.00%) low mild 2 (2.00%) high mild 4 (4.00%) high severe decode 1048576 bytes, mask 3f:time: [1.7921 ms 1.7978 ms 1.8048 ms] Found 8 outliers among 100 measurements (8.00%) 1 (1.00%) low mild 1 (1.00%) high mild 6 (6.00%) high severe 1000 streams of 1 bytes/multistream:time: [25.541 ms 25.566 ms 25.592 ms] Found 52 outliers among 500 measurements (10.40%) 51 (10.20%) high mild 1 (0.20%) high severe 1000 streams of 1000 bytes/multistream:time: [143.92 ms 143.95 ms 143.99 ms] Found 3 outliers among 500 measurements (0.60%) 3 (0.60%) high mild coalesce_acked_from_zero 1+1 entries:time: [94.504 ns 94.791 ns 95.075 ns] Found 8 outliers among 100 measurements (8.00%) 2 (2.00%) low mild 6 (6.00%) high severe coalesce_acked_from_zero 3+1 entries:time: [112.41 ns 112.62 ns 112.85 ns] Found 7 outliers among 100 measurements (7.00%) 7 (7.00%) high severe coalesce_acked_from_zero 10+1 entries:time: [112.08 ns 112.50 ns 113.00 ns] Found 25 outliers among 100 measurements (25.00%) 5 (5.00%) low severe 6 (6.00%) low mild 4 (4.00%) high mild 10 (10.00%) high severe coalesce_acked_from_zero 1000+1 entries:time: [92.563 ns 92.982 ns 93.433 ns] Found 6 outliers among 100 measurements (6.00%) 4 (4.00%) high mild 2 (2.00%) high severe RxStreamOrderer::inbound_frame():time: [117.02 ms 117.07 ms 117.13 ms] Found 16 outliers among 100 measurements (16.00%) 2 (2.00%) low severe 4 (4.00%) low mild 10 (10.00%) high mild SentPackets::take_ranges:time: [8.3415 µs 8.5607 µs 8.7710 µs] Found 19 outliers among 100 measurements (19.00%) 3 (3.00%) low severe 12 (12.00%) low mild 3 (3.00%) high mild 1 (1.00%) high severe transfer/pacing-false/varying-seeds:time: [35.714 ms 35.785 ms 35.853 ms] Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) low mild transfer/pacing-true/varying-seeds:time: [36.733 ms 36.822 ms 36.912 ms] transfer/pacing-false/same-seed:time: [35.648 ms 35.696 ms 35.744 ms] transfer/pacing-true/same-seed:time: [37.115 ms 37.174 ms 37.233 ms] Client/server transfer resultsTransfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
|
Wasn't aware of this. Cool. In favor once fix is released. |
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
==========================================
+ Coverage 94.88% 94.91% +0.02%
==========================================
Files 115 115
Lines 34256 34256
Branches 34256 34256
==========================================
+ Hits 32505 32513 +8
+ Misses 1744 1734 -10
- Partials 7 9 +2
|
|
Blocked by RalfJung/cargo-careful#39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RalfJung/cargo-careful#35 got fixed.