MPP-4236: fix(news) dont show megabundle ad for current megabundle users #5700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpremamozilla
force-pushed
the
MPP-4236-bundle-announcement-no-show-bundle-users
branch
2 times, most recently
from
0805a99 to
a967a56
Compare
groovecoder
requested changes
Jul 7, 2025
vpremamozilla
force-pushed
the
MPP-4236-bundle-announcement-no-show-bundle-users
branch
from
a967a56 to
1114e53
Compare
vpremamozilla
force-pushed
the
MPP-4236-bundle-announcement-no-show-bundle-users
branch
3 times, most recently
from
72ae0f1 to
a16fea7
Compare
vpremamozilla
force-pushed
the
MPP-4236-bundle-announcement-no-show-bundle-users
branch
from
a16fea7 to
4745be3
Compare
groovecoder
approved these changes
Jul 21, 2025
Comment on lines
+264
to
+267
| pytest.skip( | ||
| "Test requires multiple subscriptions in " | ||
| "settings.SUBSCRIPTIONS_THAT_MEGABUNDLE_PROVIDES" | ||
| ) |
There was a problem hiding this comment.
praise: nice thorough test!
groovecoder
deleted the
MPP-4236-bundle-announcement-no-show-bundle-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes MPP-4236
How to test:
log into Relay
purchase megabundle package
in-app promo in news should NOT populate
l10n changes have been submitted to the l10n repository, if any.
I've added a unit test to test for potential regressions of this bug.
I've added or updated relevant docs in the docs/ directory.
All UI revisions follow the coding standards, and use Protocol / Nebula colors where applicable (see
/frontend/src/styles/colors.scss).Commits in this PR are minimal and have descriptive commit messages.