fix MPP-4152 - refactor(e2e-tests): v2+v3 SubscriptionPaymentPage
#5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `isVersion3` check and new text getters to `SubscriptionPaymentPage`. * Updates `relay-e2e.spec.ts` to use new getters so the tests will pass on both v2 + v3 SubPlat checkout pages.
vpremamozilla
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isVersion3check and new text getters toSubscriptionPaymentPage.relay-e2e.spec.tsto use new getters so the tests will pass on both v2 + v3 SubPlat checkout pages.This PR fixes #MPP-4152.
How to test:
(Either locally or with the GitHub Action)
npx playwright test e2e-tests/specs/relay-e2e.spec.tswhile SubPlat stage is on V3 or V2l10n changes have been submitted to the l10n repository, if any.I've added a unit test to test for potential regressions of this bug.I've added or updated relevant docs in the docs/ directory.All UI revisions follow the coding standards, and use Protocol / Nebula colors where applicable (see/frontend/src/styles/colors.scss).