Skip to content

fix(e2e): increase timeout values to reduce test flakiness #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

groovecoder
Copy link
Member

@groovecoder groovecoder commented Apr 10, 2025

How to test:

  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol / Nebula colors where applicable (see /frontend/src/styles/colors.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@groovecoder groovecoder force-pushed the update-playwright-tests branch from 6a4a7ad to f78a026 Compare April 10, 2025 19:14
@groovecoder groovecoder force-pushed the update-playwright-tests branch from f78a026 to 9b88763 Compare April 10, 2025 20:31
@groovecoder
Copy link
Member Author

Latest run with new TIMEOUTS constants: https://github.com/mozilla/fx-private-relay/actions/runs/14389764516

Copy link

@b4handjr b4handjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, will be easier to change the timeouts in the future!

@groovecoder groovecoder enabled auto-merge April 10, 2025 20:47
@groovecoder groovecoder added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit e97a963 Apr 10, 2025
33 checks passed
@groovecoder groovecoder deleted the update-playwright-tests branch April 10, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants