Skip to content

fix MPP-4106: refactor(phone): update last_engagement on phone operations #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

groovecoder
Copy link
Member

This PR fixes MPP-4106.

How to test:
Unit tests should cover this.

  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol / Nebula colors where applicable (see /frontend/src/styles/colors.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@groovecoder groovecoder force-pushed the refactor-last_engagement-field-mpp-4106 branch 2 times, most recently from a27c87a to 62c8929 Compare March 11, 2025 19:44
@groovecoder groovecoder requested a review from jwhitlock March 11, 2025 19:56
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @groovecoder, looks good to me

@groovecoder groovecoder force-pushed the refactor-last_engagement-field-mpp-4106 branch from 62c8929 to ff280bb Compare March 11, 2025 22:18
@groovecoder groovecoder added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 6712c87 Mar 11, 2025
32 checks passed
@groovecoder groovecoder deleted the refactor-last_engagement-field-mpp-4106 branch March 11, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants