This repository was archived by the owner on Feb 7, 2024. It is now read-only.
fix indentation in the get_bewit function #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the code is currently written, it's impossible to generate a bewit for a URL unless
that URL has a query string. This restriction does not exist in the canonical implementation
https://github.com/hueniverse/hawk/blob/7b050d7920c52d1bb4b5ff815c41d60766a2a108/lib/client.js#L229
I have URLs that I wish to generate a bewit for which do not have query strings. I guess
I could add a bogus ?a=1 query string to the URI, but it looks more likely that the
indentation for this block of code is one level too many.