-
Notifications
You must be signed in to change notification settings - Fork 66
feat: use poetry for dependency mangement #1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c701389
to
8032afe
Compare
6b05f23
to
1d97ebe
Compare
0b47a8c
to
4121627
Compare
2aacd62
to
54f1865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With everything switched over to poetry except the Docker builds, can we remove the requirements.txt
files entirely and simply have poetry generate them for us during those builds?
I like this first step approach but, even if it's temporary, I don't think we should have the dependencies duplicated in pyproject.toml
and requirements.txt
, especially when poetry can generate it for us e.g.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
54f1865
to
84f475e
Compare
e67a357
to
c5c02b1
Compare
5fd48b4
to
526e82f
Compare
Description
To align with other Python projects, the syncserver project should use poetry for Python dependency management.
There may be some initial variance from local tests and Docker in CI, given the CI env can yield different results.
This means the incorporation of the
pyproject.toml
files with matchingpoetry.lock
files that pin dependencies.README.md
files are updated with new conventions and Dockerflow files that used to call builds using pip are replaced with Poetry.Testing
Running individual scripts with new poetry instructions. All
README.md
files are updated with Poetry and pyenv virtualenv instructions.Issue(s)
Closes STOR-258.