Skip to content

feat: use poetry for dependency mangement #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 29, 2025

Conversation

taddes
Copy link
Collaborator

@taddes taddes commented Jun 13, 2025

Description

To align with other Python projects, the syncserver project should use poetry for Python dependency management.

There may be some initial variance from local tests and Docker in CI, given the CI env can yield different results.

This means the incorporation of the pyproject.toml files with matching poetry.lock files that pin dependencies. README.md files are updated with new conventions and Dockerflow files that used to call builds using pip are replaced with Poetry.

Testing

Running individual scripts with new poetry instructions. All README.md files are updated with Poetry and pyenv virtualenv instructions.

Issue(s)

Closes STOR-258.

@taddes taddes self-assigned this Jun 13, 2025
@taddes taddes changed the title feat: use poetry for dependency mangement WIP: [CI-TESTING] feat: use poetry for dependency mangement Jun 13, 2025
@taddes taddes marked this pull request as draft June 13, 2025 16:00
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch from c701389 to 8032afe Compare June 18, 2025 13:59
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch from 6b05f23 to 1d97ebe Compare July 1, 2025 14:35
@taddes taddes changed the title WIP: [CI-TESTING] feat: use poetry for dependency mangement [CI-TESTING] feat: use poetry for dependency mangement Jul 2, 2025
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch 2 times, most recently from 0b47a8c to 4121627 Compare July 3, 2025 23:28
@taddes taddes changed the title [CI-TESTING] feat: use poetry for dependency mangement feat: use poetry for dependency mangement Jul 3, 2025
@taddes taddes marked this pull request as ready for review July 3, 2025 23:30
@taddes taddes requested a review from pjenvey July 7, 2025 21:23
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch 2 times, most recently from 2aacd62 to 54f1865 Compare July 17, 2025 20:19
Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With everything switched over to poetry except the Docker builds, can we remove the requirements.txt files entirely and simply have poetry generate them for us during those builds?

I like this first step approach but, even if it's temporary, I don't think we should have the dependencies duplicated in pyproject.toml and requirements.txt, especially when poetry can generate it for us e.g.

Comment on lines +62 to +70


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch from 54f1865 to 84f475e Compare July 22, 2025 18:33
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch from e67a357 to c5c02b1 Compare July 23, 2025 00:27
@taddes taddes requested a review from pjenvey July 28, 2025 22:24
@taddes taddes force-pushed the feat/use-poetry-for-python-STOR-258 branch from 5fd48b4 to 526e82f Compare July 28, 2025 22:28
@taddes taddes merged commit f8715d4 into master Jul 29, 2025
9 checks passed
@taddes taddes deleted the feat/use-poetry-for-python-STOR-258 branch July 29, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants