allow missing trailing slashes in chainUploadLocation #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmhodges
commented
Sep 4, 2024
jmhodges
commented
- trim leading slash before uploading chains to S3
- started as just filepath.Join(target.Path, name) in writeLocalFile
- make subtests for easier testing
- join the X5U
- remove FIXME log
- use url.JoinPath to correctly escape and join x5u and chainName
- use default http client everywhere now since we're not modifying it
Then noticed we were modifying http.Client live in the process
Need a test that ensures we're using url.JoinPath or equivalent when adding the chain name to the X5U endpoint URL.
jmhodges
force-pushed
the
allow-missing-trailing-slashes-in-chainUploadLocation
branch
from
5ab08d2 to
48e4e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.