feat: add statsd timings for admin endpoints #3467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I plan to use these in metric names, and they could do with a clean-up for consistency, brevity, and understandability.
Eijebong
reviewed
Jul 17, 2025
bhearsum
force-pushed
the
push-uxqvqslzwzkw
branch
2 times, most recently
from
073883e to
89797b9
Compare
Eijebong
reviewed
Jul 17, 2025
The most important things we need to time here are the /releases endpoints, as they are (mostly) the only ones used frequently, and we also believe them to be some of the least performant ones. I don't think there's much downside to timing just about everything though, especially considering most of them are rarely used, and won't generate data most of the time. One way I looked at doing this and ultimately rejected was using a `timer` decorator on specific handlers. This had the upside of allowing custom metric names to be set as an argument (which would've avoided renaming everything), but I decided that decorating everything was both ugly, and not very future proof (we'd probably forget to decorate things in the future).
bhearsum
force-pushed
the
push-uxqvqslzwzkw
branch
from
89797b9 to
2c13f1e
Compare
Eijebong
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important things we need to time here are the /releases endpoints, as they are (mostly) the only ones used frequently, and we also believe them to be some of the least performant ones. I don't think there's much downside to timing just about everything though, especially considering most of them are rarely used, and won't generate data most of the time.
One way I looked at doing this and ultimately rejected was using a
timerdecorator on specific handlers. This had the upside of allowing custom metric names to be set as an argument (which would've avoided renaming everything), but I decided that decorating everything was both ugly, and not very future proof (we'd probably forget to decorate things in the future).