Don't use the db_schema fixture in guardian_db
#3448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The db_schema fixture is session scopes while the guardian_db one is module scoped. If the guardian_db fixture is used in tests that get run out of order, the module fixture gets called again and explodes because it's inserting into the session database again. For example if tests are ran like this: - test_json:A - another_module:Foo - test_json:B It would result in: - db_schema - guardian_db - test_json:A - another_module:Foo - guardian_db # BOOM - test_json:B This should hopefully fix the intermittent we've been seeing in test_json
jcristau
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The db_schema fixture is session scopes while the guardian_db one is module scoped. If the guardian_db fixture is used in tests that get run out of order, the module fixture gets called again and explodes because it's inserting into the session database again.
For example if tests are ran like this:
It would result in:
This should hopefully fix the intermittent we've been seeing in test_json