Use a factory to create the app object #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
force-pushed
the
app-factory
branch
2 times, most recently
from
e75fbd3 to
ad53501
Compare
jcristau
changed the title
bhearsum
reviewed
Jul 4, 2025
There was a problem hiding this comment.
I mostly reviewed this by looking at the diff with whitespace hidden, which makes it pretty clear there's virtually no change in the non-test code, which is what I would expect.
I assume you've run docker compose locally to make sure the .wsgi parts still work?
This lets us create an app when needed instead of at import time.
cough I have now. |
bhearsum
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating the flask/connexion app at import time, do it when
create_app()is called. This makes it easier for different tests to use a different app object with different config, especially with the port to connexion 3, where some config settings aren't meant to be changed after the app has started being used.