tests: fix disabling of flask error handlers #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
approved these changes
Jun 30, 2025
|
I didn't actually add a test here :) |
Oh, heh. For some reason I read the |
|
(no pressure to actually go add something, to be clear) |
|
I've updated testGMPResponseWithSigningAutographPermanentFailure to catch this, and in doing so uncovered another bug: we were raising |
As far as I can tell this has been broken since pallets/flask@fd62210
Returning False lets python know we don't want the exception suppressed; we don't need to wrap it and raise again.
…aphPermanentFailure Ensure the exception we're getting is what we expected.
jcristau
force-pushed
the
flask-error-handler
branch
from
3c73667 to
525239d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this has been broken since
pallets/flask@fd62210