Skip to content

web: rename app to flask_app #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

jcristau
Copy link
Contributor

We have a Connexion app which wraps a Flask app, so having something called app can get confusing.

@jcristau jcristau requested a review from a team as a code owner June 30, 2025 12:07
Copy link
Contributor

@Eijebong Eijebong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to keep flask_app in tests to be consistent?

We have a Connexion app which wraps a Flask app, so having something
called `app` can get confusing.
@jcristau
Copy link
Contributor Author

Any reason not to keep flask_app in tests to be consistent?

Not really, other than I split this out of the port to connexion 3 and that'll have a bunch more changes to the tests so it was simpler this way.

@jcristau jcristau merged commit 7ec2c2b into mozilla-releng:main Jun 30, 2025
10 checks passed
@jcristau jcristau deleted the flask_app branch June 30, 2025 12:44
bhearsum added a commit to bhearsum/balrog that referenced this pull request Jun 30, 2025
Follow-up to mozilla-releng#3435 where `app` was renamed to `flask_app`.
jcristau pushed a commit that referenced this pull request Jul 1, 2025
Follow-up to #3435 where `app` was renamed to `flask_app`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants