Mozilla UI balrog #3014
Mozilla UI balrog #3014
Conversation
godplayer56
requested review from
jcristau,
gbrownmozilla and
gabrielbusta
as code owners
|
Hey @bhearsum @gabrielbusta . I was trying to fix the ui-build error which got resolved after I removed the group parameter but I am not able to fix the error with ui-tests. It shows the same error when I try to run How should I resolve these errors? Plus should I do some other changes to update the ui? |
| @@ -35,7 +36,25 @@ export default createTheme({ | |||
| }, | |||
| }, | |||
| typography: { | |||
There was a problem hiding this comment.
Can you update the theme to use the protocol pallete?
ui/.eslintrc.js
Outdated
| @@ -1,3 +1,3 @@ | |||
| const neutrino = require('neutrino'); | |||
|
|
|||
| module.exports = neutrino().eslintrc(); | |||
| module.exports = neutrino().eslintrc(); | |||
There was a problem hiding this comment.
Could you revert the changes to this file?
There was a problem hiding this comment.
I changed the file accidently in a commit 😅 , I'll revert the changes
Yes I agree! The color palette would look nicer and in line with the protocol. I'll update the theme to use the protocol palette. |
|
@gabrielbusta I have removed the balrog.svg file from the background and updated the pallette, do we need anymore changes? |
|
Hey @gabrielbusta just a follow up on this. 😅 |
There was a problem hiding this comment.
It looks good to me @godplayer56
Just one more question before I land it. I am not sure what deleting some of the pallete styles does. Should we update those to protocol colors or leave them as is?
| }, | ||
| error: red, |
There was a problem hiding this comment.
Should these be updated? What changes when you delete these?
There was a problem hiding this comment.
When I delete them the theme changes to the original theme it was. for example the dashboard becomes blue when I delete the palette
There was a problem hiding this comment.
Oh OK I see. Can we pick similar colors from the protocol pallette?
There was a problem hiding this comment.
Yes we do have similar colours in the protocol pallette, we can pick them if they look more lively. Should I update the pallette to include those colours?
There was a problem hiding this comment.
I can't see the Logo or the pages' {title}. The Logo component should be modified for use here. balrog doesn't have a group concept like shipit. You may be able to display different protocol logos based on some value in the Dashboard component's props. Or you could simplify the Logo component to always show the Mozilla "m".
Ok I'll update the logo component 👍 |
deleting them reverts the theme to what it was before, I guess it would be better if we update those to protocol colors. What colors should we use as protocol colors? |
|
|
|
@gabrielbusta I have updated the code to include the mozilla family logo as the simple "m" logo wasn't rendering maybe because of the pallette colours we have chosen 😅 . Also should I update the pallette and to what colours? |
|
Enhancing Balrog's visual alignment with the Mozilla Protocol involves a significant improvement by updating the color palette and eliminating the background's |
I have updated the dashboard file by introducing the mozilla logo and have also updated the typography to use the mozilla-protocol
This PR is for the issue #2976
I request a review and suggestions for this PR @gabrielbusta @gbrownmozilla .