Force the use of JNA 5.17.0 #3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvandermeulen
force-pushed
the
rvm/jna-5.17.0
branch
from
22d4744 to
4ae7762
Compare
jonalmeida
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
Out of curiosity, I tested this against the lowest emulator I could find: API 23 and it works for the most part without crashes on debug, however I suspect we aren't exercising some of the same code. We should land this either way and test it out with R8 generating the APK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pick up JNA transitively by way of Glean, which is currently on version 5.14.0. However, we need to force version 5.17.0 due to Google Play's 16KB page size requirement. JNA 5.15.0+ crashes on Android <7, however, so it can't be bumped in Glean at this time. Therefore, manually force the use of version 5.17.0 at the app level since we only support running on Android 8+ now anyway.