Skip to content

Conversation

besaleli
Copy link
Contributor

@besaleli besaleli commented Oct 9, 2025

Summary Support NOTICE`

  • Added third-party license validation using go-licenses/v2
  • Created Makefile targets: check-licenses, check-notice, and notice for license management
  • Added CI workflow to validate licenses and NOTICE file on PRs to main
  • Updated release process to include NOTICE file
  • Generated NOTICE file with full license text for all dependencies
  • Updated documentation to reflect new targets

Tested GHA locally using act with:

act  pull_request -j check-license -P ubuntu-latest=catthehacker/ubuntu:act-latest --container-architecture linux/amd64 --bind

Tested Makefile targets locally too

@besaleli besaleli requested a review from peteski22 October 9, 2025 17:01
* Added third-party license validation using go-licenses/v2
* Created Makefile targets: check-licenses, check-notice, and notice for license management
* Added CI workflow to validate licenses and NOTICE file on PRs to main
* Updated release process to include NOTICE file instead of individual license files
* Generated NOTICE file with full license text for all dependencies
* Updated documentation to reflect new targets

Tested GHA locally using 'act' with:

act  pull_request -j check-license -P ubuntu-latest=catthehacker/ubuntu:act-latest --container-architecture linux/amd64 --bind

Tested Makefile targets locally too
@peteski22 peteski22 force-pushed the chore/third-party-licenses branch from 9a7306c to 0d61f73 Compare October 10, 2025 13:33
Copy link
Contributor

@peteski22 peteski22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 thanks for this @besaleli

@peteski22 peteski22 merged commit 15a6555 into main Oct 16, 2025
3 checks passed
@peteski22 peteski22 deleted the chore/third-party-licenses branch October 16, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants