Normalize API output to match stored configuration format (.mcpd.toml)
#178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Normalize server names in health.go ToAPIType method * Normalize tool names in tools.go ToAPIType method * Update API tests to expect normalized output * Document ToAPIType normalization responsibility in convert interface This ensures consistent normalized output at the API boundary for both server names and tool names, resolving inconsistencies between CLI search results and daemon API responses. Related to #177
* Add UnmarshalJSON methods for MCPRegistry, Server, and Tool types * Normalize map keys and Name fields during JSON unmarshaling * Add comprehensive unit tests for unmarshaling behavior * Fix registry to use normalized server names for ID and Name fields * Add integration test with file URL and mixed-case test data This ensures server and tool names are normalized at data ingestion time, making normalization transparent and impossible to bypass. Related to #177
* Add UnmarshalJSON methods for MCPServers, MCPServer, and Tool types * Normalize map keys and Name fields during JSON unmarshaling * Add comprehensive unit tests for unmarshaling behavior * Fix registry to use normalized server names for ID and Name fields * Add integration test with file URL and mixed-case test data This ensures server and tool names are normalized at data ingestion time for MCPM registry sources, maintaining consistency with the mozilla-ai provider implementation. Related to #177
aittalam
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Thanks Peter! Overall looks good, I have just one concern re: the repeated code (unmarashaljson + tests) on mcpm + mozilla_ai repos. As we know mcpm is to be removed soon I would not bother too much, but let's keep it in the back of our heads that in case we add other registries we should factor this out to avoid redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves inconsistent normalization between CLI search results and daemon API responses.
Previously,
mcpd searchwould return non-normalized data from registry JSON manifests while the daemon API would return normalized data from internal storage, which could cause user confusion when server IDs and tool names had different casing.Changes
ToAPIType()methods to ensure consistent output at the API boundaryCloses: #177