Add Hot Reload Support for MCP Server Configurations #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
force-pushed
the
peteski22/150/reload-config
branch
from
a6faa80 to
4353db9
Compare
aittalam
reviewed
Sep 8, 2025
aittalam
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Thanks @peteski22 for this PR! I tested your branch with addition/remova/changes in the configs (both the .mcpd.toml file and the secrets file with parameters) and it works as expected.
The code LGTM (take it with a grain of salt given my expertise in go 😅), thanks for updating tests and documentation too!
* Added documentation * Implement equality checks for Server (ServerEntry and ServerExecutionContext) * Added 'UpdateTools' to MCPClientAccessor (ClientManager) * Update 'reload' logic for MCP servers to handle tool only changes etc. *
peteski22
force-pushed
the
peteski22/150/reload-config
branch
from
4353db9 to
5f5d2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
This PR implements hot reload functionality for
mcpd, allowing dynamic reconfiguration of MCP servers without daemon restart viaSIGHUPsignal.TL;DR
SIGHUPSignal Handling: Sendkill -HUP <PID>to trigger configuration reloaddocs/configuration.md(/mcpd/configuration/#hot-reload)Closes: #150
SIGHUPno changes:SIGHUPremoved tools fromjiraleaving onlysearch_jira_issues:SIGHUPremovedjiraserver:SIGHUPaddedduckduckgo-mcp: