BREAKING: Split RequiredArgs into RequiredValueArgs and RequiredBoolArgs #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change provides more granular control over argument validation by separating value-based arguments (e.g., --config=value) from boolean flags (e.g., --verbose). BREAKING CHANGE: The TOML configuration structure has changed. - `required_args` is now split into `required_args` (value args) and `required_args_bool` (boolean flags) - Existing .mcpd.toml files using `required_args` will need to be updated Changes: - Split ServerEntry.RequiredArgs into RequiredValueArgs and RequiredBoolArgs - Add VariableTypeArgBool constant for boolean argument classification - Add ValueArgument and BoolArgument predicate functions - Update cmd/add.go to use new argument filtering logic - Add comprehensive test coverage for new argument types - Add validation methods for both argument types in runtime.Server - Update daemon validation to use new Server.Validate() method - Update printer to display both argument types appropriately - Enhance registry to properly detect boolean vs value arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides more granular control over argument validation by separating value-based arguments (e.g.,
--config=value) from boolean flags (e.g.,--verbose).BREAKING CHANGE: The TOML configuration structure has changed.
required_argsis now split intorequired_args(value args) andrequired_args_bool(boolean flags).mcpd.toml filesusingrequired_argsmay need to be updated if they contain boolean flag args in their listChanges:
intoRequiredValueArgsandRequiredBoolArgs`VariableTypeArgBoolconstant for boolean argument classificationValueArgumentandBoolArgumentpredicate functionscmd/add.goto use new argument filtering logicruntime.ServerServer.Validate()method