Skip to content

Replace rclcpp::Rate with rclcpp::WallRate #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

onionsflying
Copy link
Contributor

Description

rclcpp::WallRate is preferable to rclcpp::Rate, because with rclcpp::WallRate rate.sleep() won’t stall due to backward system clock adjustments (e.g., a one-day rollback).

Copy link

mergify bot commented Aug 17, 2025

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

Copy link

codecov bot commented Aug 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.95%. Comparing base (3f2d7f5) to head (e42e7f3).
⚠️ Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...nitor/src/trajectory_monitor_middleware_handle.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #3557   +/-   ##
=======================================
  Coverage   50.95%   50.95%           
=======================================
  Files         390      390           
  Lines       32521    32521           
=======================================
  Hits        16567    16567           
  Misses      15954    15954           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant