-
Notifications
You must be signed in to change notification settings - Fork 657
moveit_ros_benchmarks: Require cxx_std_20 compile feature #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3509 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 181 181
Lines 22649 22649
Branches 3108 3108
=====================================
Misses 22649 22649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
The PR is not obsolete. I just rebased on main, hopefully this should fix the CI. As the bot asked me to a tag a mantainer, I will tag @JafarAbdi that handled several related PRs in the past (thanks!). |
Unfortunatly somehow the CI are all failing, even if at first glance I do not see how the CI failures are related to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll take a look at CI later today |
Description
Since #1539 the
moveit_ros_benchmarks
library uses internally the designated initializers feature, that is only available in C++ 20 (see https://en.cppreference.com/w/cpp/language/aggregate_initialization.html#Designated_initializers).It seems that GCC and Clang permits to use designated initializers even in C++17 mode, but MSVC instead raise an error like:
see https://github.com/RoboStack/ros-kilted/actions/runs/15800837297/job/44538772389#step:6:3639 .
This PR fixes this by requesting the use at least of C++ 20 features with
target_compile_features(moveit_ros_benchmarks PRIVATE cxx_std_20)
.Checklist