Skip to content

moveit_ros_benchmarks: Require cxx_std_20 compile feature #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 22, 2025

Description

Since #1539 the moveit_ros_benchmarks library uses internally the designated initializers feature, that is only available in C++ 20 (see https://en.cppreference.com/w/cpp/language/aggregate_initialization.html#Designated_initializers).

It seems that GCC and Clang permits to use designated initializers even in C++17 mode, but MSVC instead raise an error like:

2025-06-22T00:10:29.7938610Z  │ │ %SRC_DIR%\ros-kilted-moveit-ros-benchmarks\src\work\src\BenchmarkExecutor.cpp(811,9): error C7555: use of designated initializers requires at least '/std:c++20' [%SRC_DIR%\build\moveit_ros_benchmarks.vcxproj]
2025-06-22T00:10:29.8041863Z  │ │ %SRC_DIR%\ros-kilted-moveit-ros-benchmarks\src\work\src\BenchmarkExecutor.cpp(906,11): error C7555: use of designated initializers requires at least '/std:c++20' [%SRC_DIR%\build\moveit_ros_benchmarks.vcxproj]

see https://github.com/RoboStack/ros-kilted/actions/runs/15800837297/job/44538772389#step:6:3639 .

This PR fixes this by requesting the use at least of C++ 20 features with target_compile_features(moveit_ros_benchmarks PRIVATE cxx_std_20).

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3e526af) to head (7638f53).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3509   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        181     181           
  Lines      22649   22649           
  Branches    3108    3108           
=====================================
  Misses     22649   22649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Aug 18, 2025
@traversaro traversaro closed this Aug 18, 2025
@traversaro traversaro reopened this Aug 18, 2025
@traversaro
Copy link
Contributor Author

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

The PR is not obsolete. I just rebased on main, hopefully this should fix the CI. As the bot asked me to a tag a mantainer, I will tag @JafarAbdi that handled several related PRs in the past (thanks!).

@traversaro
Copy link
Contributor Author

should fix the CI

Unfortunatly somehow the CI are all failing, even if at first glance I do not see how the CI failures are related to the PR.

@JafarAbdi JafarAbdi removed the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Aug 18, 2025
Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JafarAbdi
Copy link
Member

I'll take a look at CI later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants