Skip to content

Provide default seed value in TrainConfig, matching EvalConfig #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Provide default seed value in TrainConfig, matching EvalConfig #1315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2053d
Update config_utils.py
mvpatel2000 Jun 28, 2024
833f044
lint
mvpatel2000 Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llmfoundry/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,10 @@ class TrainConfig:
max_duration: Union[int, str] = MISSING
eval_interval: Union[int, str] = MISSING
max_seq_len: int = MISSING
seed: int = MISSING

# Seed
seed: int = 17

# Precision
precision: str = 'amp_bf16'

Expand Down